Re: TAP tests and symlinks on Windows
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-06-09T07:28:04Z
Lists: pgsql-hackers
On 2020-06-09 09:19, Michael Paquier wrote: > On Mon, Jun 08, 2020 at 02:44:31PM +0200, Peter Eisentraut wrote: >> both contain a TAP skip notice "symlinks not supported on Windows". >> >> This is untrue. Symlinks certainly work on Windows, and we have other TAP >> tests using them, for example for tablespaces. > >> pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just remove >> the skip stuff. My attached patch does that. > > What's the version of your perl installation on Windows? With 5.22, I > am still seeing that symlink() is not implemented, causing the tests > of pg_rewind to blow in flight with your patch (MSVC 2015 here). I was using MSYS2 and the Perl version appears to have been 5.30.2. Note sure which one of these two factors makes the difference. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Enable almost all TAP tests involving symlinks on Windows
- d66b23b032d7 14.0 landed