Re: DROP OWNED BY fails to clean out pg_init_privs grants
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
Hannu Krosing <hannuk@google.com>,
"David G. Johnston" <david.g.johnston@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Stephen Frost <sfrost@snowman.net>,
Andres Freund <andres@anarazel.de>,
Noah Misch <nmisch@google.com>
Date: 2024-06-17T16:37:47Z
Lists: pgsql-hackers
> On 17 Jun 2024, at 16:56, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Daniel Gustafsson <daniel@yesql.se> writes: >> I wonder if this will break any tools/scripts in prod which relies on the >> previous (faulty) behaviour. It will be interesting to see if anything shows >> up on -bugs. Off the cuff it seems like a good idea judging by where we are >> and what we can fix with it. > > Considering that SHARED_DEPENDENCY_INITACL has existed for less than > two months, it's hard to believe that any outside code has grown any > dependencies on it, much less that it couldn't be adjusted readily. Doh, I was thinking about it backwards, clearly not a worry =) >> I wonder if it's worth reverting passing the owner ID for v17 and revisiting >> that in 18 if we work on recording the ID. Shaving a few catalog lookups is >> generally worthwhile, doing them without needing the result for the next five >> years might bite us. > > Yeah, that was the direction I was leaning in, too. I'll commit the > revert of that separately, so that un-reverting it shouldn't be too > painful if we eventually decide to do so. Sounds good. -- Daniel Gustafsson
Commits
-
Allow meson builds to run test_pg_dump test in installcheck mode.
- f663f4daf075 16.5 landed
- b0c5b215dace 17.0 landed
-
Remove recordExtensionInitPriv[Worker]'s ownerId argument.
- ba26d156636c 17.0 landed
-
Improve tracking of role dependencies of pg_init_privs entries.
- 35dd40d34cbd 17.0 landed
-
Fix failure to track role dependencies of pg_init_privs entries.
- 534287403914 17.0 landed
-
Drop global objects after completed test
- 936e3fa3787a 17.0 cited