Re: possible deadlock: different lock ordering for heap pages

Nishant, Fnu <nishantf@amazon.com>

View thread View on postgr.es

From: "Nishant, Fnu" <nishantf@amazon.com>

To: Amit Kapila <amit.kapila16@gmail.com>, Robert Haas <robertmhaas@gmail.com>

Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2019-01-21T17:09:38Z

Lists: pgsql-hackers

Attachments

lock-order.patch (application/octet-stream) patch

Thanks Amit for your review.

On 1/20/19, 6:55 AM, "Amit Kapila" <amit.kapila16@gmail.com> wrote:
    > I think you need to change below code as well....
       Assert(buffer2 == InvalidBuffer || buffer1 <= buffer2);

Done. Updated the patch.

Will wait for Robert comments.

Thanks
-Nishant

Commits

Avoid possible deadlock while locking multiple heap pages.
- 0b8bdb3c3ec0 12.0 landed
- fba0a8292997 9.4.21 landed
- 6a2c9c633135 9.5.16 landed
- 073afae81989 9.6.12 landed
- 1ca33fc7b511 10.7 landed
- 904413637f8b 11.2 landed
Try again to make the visibility map crash safe.
- e16954f3d27f 9.2.0 cited