Horton

Re: BUG #16419: wrong parsing BC year in to_date() function

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-30T19:11:06Z
Lists: pgsql-bugs, pgsql-hackers 
Bruce Momjian <bruce@momjian.us> writes:
> On Wed, Sep 30, 2020 at 02:50:31PM -0400, Tom Lane wrote:
>> Actually, I was just finishing up back-patching the patch I posted
>> yesterday.  I think we should just fix it, not document that it's
>> broken.

> Agreed, that's what I wanted.  You stated in a later email you couldn't
> convince yourself of the backpatch, which is why I asked.

Oh, I see where our wires are crossed.  I meant that I couldn't
convince myself to back-patch the make_timestamp() change.
(I'm still willing to listen to an argument to do so, if anyone
wants to make one --- but that part feels more like a feature
addition than a bug fix.)

			regards, tom lane

Commits

  1. Fix handling of BC years in to_date/to_timestamp.

  2. Fix make_timestamp[tz] to accept negative years as meaning BC.

  3. doc: PG 13 relnotes, update TOAST item to mention decompression