Re: typedef struct WindowClause misleading comments
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: jian he <jian.universality@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-06-09T16:54:49Z
Lists: pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes: > On Tue, 9 Jun 2026 at 13:56, jian he <jian.universality@gmail.com> wrote: >> Query jumbling considers the ORDER BY clause; therefore, the comment >> below is inaccurate. >> >> / >> * The information relevant for the query jumbling is the partition clause >> * type and its bounds. >> */ > I think the comment should be deleted. It's pretty obvious which > fields are used by looking at the pg_node_attr(query_jumble_ignore) > attributes. +1. There are also other comments about query jumbling in nodes/*.h that seem pretty information-free now. They might have been helpful before we invented query_jumble_ignore and related annotations, but now they seem just duplicative. regards, tom lane
Commits
-
Fix various query jumble comments
- e5f94c4808fe 19 (unreleased) landed