Re: Uh, I change my mind about commit_delay + commit_siblings (sort of)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <peter@2ndQuadrant.com>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2012-05-31T14:00:28Z
Lists: pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes: > On 31 May 2012 13:16, Robert Haas <robertmhaas@gmail.com> wrote: >> Frankly, I think this whole thing should be pushed to 9.3. > What matters is that we have a patch that provides a massive > performance gain in write performance in just a few lines of code, and > that should be committed to 9.2. I agree with Robert on this. This patch hasn't had *nearly* enough testing to justify cramming it into 9.2 at this point. AFAIK the claim of "massive performance gain" is based on a single test case run by a single person, which doesn't even give me any confidence that it doesn't break anything, much less that it's a win across the board. If we want to finish the beta cycle in a reasonable time period and get back to actual development, we have to refrain from adding more possibly-destabilizing development work to 9.2. And that is what this is. Add it to the upcoming CF, please. regards, tom lane