Horton

Re: Violation of principle that plan trees are read-only

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-05-20T21:01:11Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. In ExecInitModifyTable, don't scribble on the source plan.

  2. Rely on executor utils to build targetlist for DML RETURNING.

Andres Freund <andres@anarazel.de> writes:
> On 2025-05-20 16:18:57 -0400, Tom Lane wrote:
>> I'm curious though: what was the test case you were looking at?

> It's a modified query from our regression tests, I had added some debugging to
> find cases where the targetlists differed.  I attached the extracted, somewhat
> modified, sql script.

[ confused... ]  I get the same output from that script with or
without the patch.

			regards, tom lane