Re: log bind parameter values on error
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alexey Bashtanov <bashtanov@imap.cc>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-01-03T11:56:58Z
Lists: pgsql-hackers
On 02/01/2019 23:53, Alexey Bashtanov wrote: >> In fact, maybe don't use the Portal structure at all and just store the >> saved textualized values inside postgres.c in a static variable. > > Unlike SQL, parameters may spend much more memory, so I'd have them > in portal memory context to make sure the memory is released earlier > rather than later. Having them in the portal structure is different from having it in the portal memory context. Although there is perhaps value in keeping them together. > Do you think it would be acceptable to leave them cached in parameters > structure? Let's see how it looks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Emit parameter values during query bind/execute errors
- ba79cb5dc841 13.0 landed
-
Add backend-only appendStringInfoStringQuoted
- 6cafde1bd43f 13.0 landed