Re: Australian timezone configure option

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Chris Dunlop <chris@onthe.net.au>, pgsql-patches@postgresql.org
Date: 2001-06-12T16:22:29Z
Lists: pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Here is a new version of the patch.

It's still horridly ugly.  Why not put the three Aussie-specific entries
in a separate aussie_datetktbl array, and have the lookup look like

    if (Australian_timezones)
    {
        tp = datebsearch(lowtoken, aussie_datetktbl, sz_aussie_datetktbl);
        if (tp == NULL)
            tp = datebsearch(lowtoken, datetktbl, szdatetktbl);
    }
    else
        tp = datebsearch(lowtoken, datetktbl, szdatetktbl);

instead of modifying the lookup table on the fly.

> I found I didn't need to clear the date cache.

Hmm, are you sure about that?  I'm not.

			regards, tom lane