Horton

Re: unused_oids script is broken with bsd sed

Andreas Karlsson <andreas@proxel.se>

View thread View on postgr.es
From: Andreas Karlsson <andreas@proxel.se>
To: John Naylor <jcnaylor@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, David Fetter <david@fetter.org>
Date: 2018-04-26T12:54:17Z
Lists: pgsql-hackers 
On 04/26/2018 01:37 PM, John Naylor wrote:> Patch 0002 is my attempt at 
this. Not sure how portable this is. It's
> also clunkier than before in that you need to tell it where to find
> Catalog.pm, since it seems Perl won't compile unless "use lib" points
> to a string and not an expression. Suggestions welcome. I also edited
> the boilerplate comments.

What about using FindBin (http://perldoc.perl.org/FindBin.html)?

Andreas

Commits

  1. Blindly try to fix MSVC build's use of genbki.pl and Gen_fmgrtab.pl.

  2. Avoid overwriting unchanged output files in genbki.pl and Gen_fmgrtab.pl.

  3. Rearrange makefile rules for running Gen_fmgrtab.pl.

  4. Avoid parsing catalog data twice during BKI file construction.

  5. Fix duplicate_oids and unused_oids so user needn't cd to catalog dir.

  6. Convert unused_oids and duplicate_oids to use Catalog.pm infrastructure.

  7. Make Catalog.pm's representation of toast and index decls more abstract.