Re: Add Nullif case for eval_const_expressions_mutator
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-11T16:20:53Z
Lists: pgsql-hackers
"Hou, Zhijie" <houzj.fnst@cn.fujitsu.com> writes: > I notice that there are no Nullif case in eval_const_expression. > Since Nullif is similar to Opexpr and is easy to implement, > I try add this case in eval_const_expressions_mutator. I think this patch should be about a tenth the size. Try modeling it on the T_SubscriptingRef-etc case, ie, use ece_generic_processing and then ece_evaluate_expr to cover the generic cases. OpExpr is common enough to deserve specially optimized code, but NullIf isn't, so shorter is better. regards, tom lane
Commits
-
Add support for NullIfExpr in eval_const_expressions
- 9c5f67fd6256 14.0 landed