Re: new function for tsquery creartion
Aleksandr Parfenov <a.parfenov@postgrespro.ru>
From: Aleksandr Parfenov <a.parfenov@postgrespro.ru>
To: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: Dmitry Ivanov <d.ivanov@postgrespro.ru>, Thomas Munro
<thomas.munro@enterprisedb.com>, David Steele <david@pgmasters.net>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-04-01T12:51:03Z
Lists: pgsql-hackers
Attachments
- websearch_to_tsquery_v3.diff (text/x-diff) patch v3
Hello hackers, On 2018-03-28 12:21, Aleksander Alekseev wrote: > It doesn't sound right to me to accept any input as a general rule but > sometimes return errors nevertheless. That API would be complicated for > the users. Thus I suggest to accept any garbage and try our best to > interpret it. I agree with Aleksander about silencing all errors in websearch_to_tsquery(). In the attachment is a revised patch with the attempt to introduce an ability to ignore syntax errors in gettoken_tsvector(). I'm also read through the patch and all the code looks good to me except one thing. The name of enum ts_parsestate looks more like a name of the function than a name of a type. In my version, it renamed to QueryParserState, but you can fix it if I'm wrong. -- Aleksandr Parfenov Postgres Professional: http://www.postgrespro.com Russian Postgres Company
Commits
-
Add websearch_to_tsquery
- 1664ae1978bf 11.0 landed
-
Add psql variables to track success/failure of SQL queries.
- 69835bc89888 11.0 cited
-
Wording improvements
- f5f1355dc4dc 8.3.0 cited