Re: using index or check in ALTER TABLE SET NOT NULL

Sergei Kornilov <sk@zsrv.org>

From: Sergei Kornilov <sk@zsrv.org>

To: Ildar Musin <i.musin@postgrespro.ru>, Stephen Frost <sfrost@snowman.net>

Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2018-03-06T15:52:58Z

Lists: pgsql-hackers

Attachments

alter_table_set_not_null_by_constraints_only_v6.patch (text/x-diff) patch v6

Hello, Ildar
Thanks. I looked ATTACH PARTITION tests and found such checks. If no one is against i will just use in my patch INFO level instead DEBUG1, similarly ATTACH PARTITION code. Updated patch attached.

Or i can rewrite tests to use DEBUG1 level.

regards, Sergei

Commits

Avoid using INFO elevel for what are fundamentally debug messages.
- db438318997b 13.0 landed
- 121e3ceed6d9 12.0 landed
Revert setting client_min_messages to 'debug1' in new tests.
- 5655565c077c 12.0 landed
Allow ALTER TABLE .. SET NOT NULL to skip provably unnecessary scans.
- bbb96c3704c0 12.0 landed
Improve predtest.c's internal docs, and enhance its functionality a bit.
- 5748f3a0aa7c 11.0 cited