Horton

Re: Warn when parallel restoring a custom dump without data offsets

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Gilman <dgilman@gilslotd.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2020-07-02T21:25:21Z
Lists: pgsql-hackers 
David Gilman <dgilman@gilslotd.com> writes:
> I've attached the latest patches after further review from Justin Pryzby.

I guess I'm completely confused about the purpose of these patches.
Far from coping with the situation of an unseekable file, they appear
to change pg_restore so that it fails altogether if it can't seek
its input file.  Why would we want to do this?

			regards, tom lane

Commits

  1. Cope with data-offset-less archive files during out-of-order restores.

  2. Remove manual tracking of file position in pg_dump/pg_backup_custom.c.

  3. Improve performance of tuple conversion map generation

  4. Fix pg_restore so parallel restore doesn't fail when the input file doesn't