Horton

Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>
Cc: Magnus Hagander <magnus@hagander.net>, Tatsuo Ishii <ishii@sraoss.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-01-07T04:49:49Z
Lists: pgsql-hackers

Attachments

Thanks for reviewing.

On 2018/12/31 20:23, Peter Eisentraut wrote:
> On 06/12/2018 05:46, Amit Langote wrote:
>>  	/*
>>  	 * We currently only support writing to regular tables.
>>  	 */
> 
> I think that comment should stay above the code you are adding.

Do you mean to keep it at the top and expand it to mention the point about
partitioned and foreign tables, like this:

     /*
-     * We currently only support writing to regular tables.
+     * We currently only support writing to regular tables.  However, give
+     * a more specific error for partitioned and foreign tables.
      */
+    if (relkind == RELKIND_PARTITIONED_TABLE)

If so, that makes sense.  I've updated the patch like that.

Thanks,
Amit

Commits

  1. Improve error messages for incorrect types of logical replication targets