Remove HeapTupleheaderSetXmin{Committed,Invalid} functions

Andy Fan <zhihuifan1213@163.com>

From: Andy Fan <zhihuifan1213@163.com>

To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-06-25T07:47:27Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove HeapTupleheaderSetXminCommitted/Invalid functions
- cbef472558ca 19 (unreleased) landed
Convert macros to static inline functions (htup_details.h, itup.h)
- 34694ec888d6 18.0 cited
Change the way we mark tuples as frozen.
- 37484ad2aace 9.4.0 cited
Code review for HeapTupleHeader changes. Add version number to page headers
- c7a165adc64e 7.3.1 cited
This patch wraps all accesses to t_xmin, t_cmin, t_xmax, and t_cmax in
- 3c35face4108 7.3.1 cited

Attachments

v1-0001-Remove-HeapTupleheaderSetXminCommitted-Invalid-fu.patch (text/x-diff)

Hi,

When I am reading the code, I first thought I can do something in
HeapTupleheaderSetXminCommitted, then I realized we have SetHintBits.
After some research, I find HeapTupleHeaderSetXminCommitted is never
used and it looks not safe to use after comparing with SetHintBits. So
to avoid future confusion or misuse, I'd suggest to remove it. I think
HeapTupleHeaderSetXminInvalid should be the same. So here is the patch.

commit ed905d64c6b81a78627f895918d4ac723d46865c (HEAD -> heap_set_bits)
Author: Andy Fan <zhihuifan1213@163.com>
Date:   Wed Jun 25 07:35:32 2025 +0000

    Remove HeapTupleheaderSetXminCommitted/Invalid functions
    
    They are neither be used nor be safe to be used, User should use
    SetHintBits instead.

What do you think?

-- 
Best Regards
Andy Fan