Horton

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner <vitus@wagner.pp.ru>
Date: 2018-09-04T16:38:50Z
Lists: pgsql-hackers 
>>>>> "Andres" == Andres Freund <andres@anarazel.de> writes:

 >> However, this commit broke float8 test on 32-bit FreeBSD 11 with
 >> clang 3.8.0 compiler. Regressions.diff follows:

 Andres> Does this happen with a newer clang version too?

float8 test (and all other tests) passes for me on clang 3.9.1 on fbsd11
on 32-bit ARM, and on -m32 builds on amd64.

I also confirmed that without #define isinf(x) __builtin_isinf(x), on
both 32bit and 64bit fbsd isinf() compiles as a function call, so the
OP's proposed change would not be desirable.

-- 
Andrew (irc:RhodiumToad)

Commits

  1. Error out for clang on x86-32 without SSE2 support, no -fexcess-precision.

  2. Fix 8a934d677 for libc++ and make more include order resistant.