Re: Another review of URI for libpq, v7 submission

Alex Shulgin <ash@commandprompt.com>

From: Alex <ash@commandprompt.com>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2012-03-27T22:49:40Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor to eliminate duplicate copies of conninfo default-finding code.
- e9ce658b6203 9.2.0 cited

Attachments

libpq-uri-v10.patch.gz (application/octet-stream) patch v10

Alex <ash@commandprompt.com> writes:

> Peter Eisentraut <peter_e@gmx.net> writes:
>>
>> Attached is a patch on top of your v9 with two small fixes:
>>
>> - Don't provide a check target in libpq/Makefile if it's not
>> implemented.
>>
>> - Use the configured port number for running the tests (otherwise it
>> runs against my system installation, for example).
>
> Neat, thank you.

Attached is a gzipped v10, complete with the above fixes and fixes to
bugs found by Heikki.  Documentation and code comments are also finally
updated.

Of all the command-line utilities which can accept conninfo string, only
psql mentions that, so only its documentation was updated.  Other
utilities, like pg_dump and pg_restore can also work with either
conninfo or URI, however this remains undocumented.

--
Alex