Re: Comment in portal.h
Andy Fan <zhihuifan1213@163.com>
From: Andy Fan <zhihuifan1213@163.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-07-30T23:55:39Z
Lists: pgsql-hackers
Etsuro Fujita <etsuro.fujita@gmail.com> writes: > Hi, > > I noticed $SUBJECT while working on something else: > > /* > * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or > * PORTAL_UTIL_SELECT query. (A cursor held past the end of its > * transaction no longer has any active executor state.) > */ > Tuplestorestate *holdStore; /* store for holdable cursors */ > MemoryContext holdContext; /* memory containing holdStore */ > > We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be > "Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING, > PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.". Attached is a > patch for that. Patch looks good to me. All the codes of PortalRun & FillPortalStore & PortalRunSelect are consistent with this idea. -- Best Regards Andy Fan
Commits
-
Update comment in portal.h.
- fba830573335 12.20 landed
- 13fa22621002 13.16 landed
- 4c61a3a46817 14.13 landed
- d7bc9c9d04ad 15.8 landed
- 0540b5fd43d0 16.4 landed
- eb39497eed29 17.0 landed
- e66b32e43b22 18.0 landed