Re: Hash support for grouping sets
Andrew Gierth <andrew@tao11.riddles.org.uk>
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <hornschnorter@gmail.com>, pgsql-hackers@postgresql.org
Date: 2017-03-23T22:45:36Z
Lists: pgsql-hackers
>>>>> "Andres" == Andres Freund <andres@anarazel.de> writes: Andres> We usually cast the result of palloc. >> Rough count in the backend has ~400 without casts to ~1350 with, so >> this doesn't seem to have been consistently enforced. Andres> Yea, but we're still trying. Well, a lot of the uncasted ones are in fairly new code, from quite a number of different committers. So if this is a big deal, why don't we already have #define palloc_array(etype,ecount) (((etype) *) palloc((ecount) * sizeof(etype))) #define palloc_object(otype) (((otype) *) palloc(sizeof(otype))) or something of that ilk? -- Andrew (irc:RhodiumToad)
Commits
-
Support hashed aggregation with grouping sets.
- b5635948ab16 10.0 landed