Re: A assert failure when initdb with track_commit_timestamp=on

Andy Fan <zhihuifan1213@163.com>

From: Andy Fan <zhihuifan1213@163.com>

To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

Cc: 'Michael Paquier' <michael@paquier.xyz>, Fujii Masao <masao.fujii@oss.nttdata.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-07-03T13:31:23Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Disable commit timestamps during bootstrap
- 8bca4476f9f9 13.22 landed
- b61ddcaf41cf 14.19 landed
- dcbbd43317c0 15.14 landed
- 7e7059abfd22 16.10 landed
- ae20c105f0b2 17.6 landed
- 29a4b63c6bc8 18.0 landed
- 5a6c39b6df33 19 (unreleased) landed

Attachments

v3-0001-Avoid-activating-commit_ts-while-bootstrap.patch (text/x-diff)

"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com> writes:

> Dear Michael, Fujii-san,
>
>> Ah, indeed, so it was reported a couple of months ago.  I am not sure
>> that the argument about all the other GUCs potentially impacted holds
>> much value; we are talking about a specific code path.
>
> Yeah, I did report but sadly it was missed by others :-(. To clarify,
> The current patch looks good to me.

Then I'd thank Michael to watch the maillist closely this time. 

I checked the fix suggested by Hayato, I think his patch is better than
me because his patch checks at the startup time while my patch checks at
each time of RecordTransactionCommit. So v3 takes his patch. v3 also
added the testcase suggested by Michael for test coverage, it clearly
proves the bug is fixed now.

-- 
Best Regards
Andy Fan