Horton

Re: Ryu floating point output patch

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, pgsql-hackers@postgresql.org, "David G. Johnston" <david.g.johnston@gmail.com>, Donald Dong <xdong@csumb.edu>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Chapman Flack <chap@anastigmatix.net>
Date: 2019-02-17T16:19:05Z
Lists: pgsql-hackers 
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 >> b) new command-line option, e.g. pg_dump --extra-float-digits=0

 >> This is probably the safest option, IMO. Any preferences as to the
 >> option name?

 Tom> I like that too, assuming that it can be made to fit into the
 Tom> structure of the cross-version-upgrade tests (which would have
 Tom> to know to use it only with >= v12 pg_dump).

 Tom> --extra-float-digits seems fine as a name.

As far as I can tell, test.sh only uses the new version's pg_dump (in
fact the only binaries directly used from the old version are initdb and
pg_ctl).

... wait, this initdb in test.sh is using an option that doesn't exist
before pg11? Is the cross-version test actually using some different
script? Andrew?

-- 
Andrew (irc:RhodiumToad)

Commits

  1. Provide an extra-float-digits setting for pg_dump / pg_dumpall

  2. Change floating-point output format for improved performance.

  3. Use strtof() and not strtod() for float4 input.