Horton

Thread

Commits

  1. Improve <xref> vs. <command> formatting in the documentation

  2. Add missing <application> tags in application doc <refentrytitle>s

  1. <xref> vs <command> formatting in the docs

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2020-06-21T15:22:04Z

    Hi Hackers,

While looking at making more <command>SQL</command> into links, I
noticed that <xref> loses the monospace formatting of <command>, and
can't itself be wrapped in <command>.  This becomes particularly
apparent when you have one link that can be an <xref/> next to another
that's <link><command>...</command></link> because it's actually
referring to a specific variant of the command.

By some trial and error I found that putting <command> inside the
<refentrytitle> tag propagates the formatting to the <xref> contents.
We already do this with <application> for (most of) the client and
server applications.  Is this something we want to do consistently for
both?

- ilmari
-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law

  2. Re: <xref> vs <command> formatting in the docs

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2020-06-21T15:30:38Z

    On 2020-Jun-21, Dagfinn Ilmari Mannsåker wrote:

> While looking at making more <command>SQL</command> into links, I
> noticed that <xref> loses the monospace formatting of <command>, and
> can't itself be wrapped in <command>.

Ouch.

> By some trial and error I found that putting <command> inside the
> <refentrytitle> tag propagates the formatting to the <xref> contents.
> We already do this with <application> for (most of) the client and
> server applications.  Is this something we want to do consistently for
> both?

Looking at the ones that use <application>, it looks like manpages are
not damaged, so +1.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  3. Re: <xref> vs <command> formatting in the docs

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2020-06-21T16:57:45Z

    Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> On 2020-Jun-21, Dagfinn Ilmari Mannsåker wrote:
>
>> While looking at making more <command>SQL</command> into links, I
>> noticed that <xref> loses the monospace formatting of <command>, and
>> can't itself be wrapped in <command>.
>
> Ouch.
>
>> By some trial and error I found that putting <command> inside the
>> <refentrytitle> tag propagates the formatting to the <xref> contents.
>> We already do this with <application> for (most of) the client and
>> server applications.  Is this something we want to do consistently for
>> both?
>
> Looking at the ones that use <application>, it looks like manpages are
> not damaged, so +1.

Attached are two patches: the first adds the missing <application> tags,
the second adds <command> to all the SQL commands (specifically anything
with <manvolnum>7</manvolnum>).

I'll add it to the commitfest.

- ilmari
-- 
- Twitter seems more influential [than blogs] in the 'gets reported in
  the mainstream press' sense at least.               - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
  to a mainstream media article.                      - Calle Dybedahl

  4. Re: <xref> vs <command> formatting in the docs

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-07-10T15:05:04Z

    On 2020-06-21 18:57, Dagfinn Ilmari Mannsåker wrote:
> Attached are two patches: the first adds the missing <application> tags,
> the second adds <command> to all the SQL commands (specifically anything
> with <manvolnum>7</manvolnum>).

I have committed the first one.

I have some concerns about the second one.  If you look at the diff of 
the source of the man pages before and after, it creates a bit of a 
mess, even though the man pages look okay when rendered.  I'll need to 
think about this a bit more.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  5. Re: <xref> vs <command> formatting in the docs

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-09-25T05:38:56Z

    On 2020-07-10 17:05, Peter Eisentraut wrote:
> On 2020-06-21 18:57, Dagfinn Ilmari Mannsåker wrote:
>> Attached are two patches: the first adds the missing <application> tags,
>> the second adds <command> to all the SQL commands (specifically anything
>> with <manvolnum>7</manvolnum>).
> 
> I have committed the first one.
> 
> I have some concerns about the second one.  If you look at the diff of
> the source of the man pages before and after, it creates a bit of a
> mess, even though the man pages look okay when rendered.  I'll need to
> think about this a bit more.

I asked about this on a DocBook discussion list.  While the general 
answer is that you can do anything you want, it was clear that putting 
markup into title elements requires more careful additional 
customization and testing, and it's preferable to handle appearance 
issues on the link source side.  (See also us dialing back the number of 
xreflabels recently.)  This is also the direction that DocBook 5 appears 
to be taking, where you can put linkend attributes into most inline 
tags, so you could maybe do <command linkend="sql-select"/>.  This 
doesn't work for us yet, but the equivalent of that would be 
<command><xref linkend="..."/></command>.

So, based on that, I think the patch proposed here is not the right one, 
and we should instead be marking up the link sources appropriately.

(This also implies that the already committed 0001 patch should be 
reverted.)

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  6. Re: <xref> vs <command> formatting in the docs

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-10-03T14:57:34Z

    On 2020-09-25 07:38, Peter Eisentraut wrote:
> So, based on that, I think the patch proposed here is not the right one,
> and we should instead be marking up the link sources appropriately.

I have committed a fix for this:

    Improve <xref> vs. <command> formatting in the documentation

    SQL commands are generally marked up as <command>, except when a link
    to a reference page is used using <xref>.  But the latter doesn't
    create monospace markup, so this looks strange especially when a
    paragraph contains a mix of links and non-links.

    We considered putting <command> in the <refentrytitle> on the target
    side, but that creates some formatting side effects elsewhere.
    Generally, it seems safer to solve this on the link source side.

    We can't put the <xref> inside the <command>; the DTD doesn't allow
    this.  DocBook 5 would allow the <command> to have the linkend
    attribute itself, but we are not there yet.

    So to solve this for now, convert the <xref>s to <link> plus
    <command>.  This gives the correct look and also gives some more
    flexibility what we can put into the link text (e.g., subcommands or
    other clauses).  In the future, these could then be converted to
    DocBook 5 style.

    I haven't converted absolutely all xrefs to SQL command reference
    pages, only those where we care about the appearance of the link text
    or where it was otherwise appropriate to make the appearance match a
    bit better.  Also in some cases, the links where repetitive, so in
    those cases the links where just removed and replaced by a plain
    <command>.  In cases where we just want the link and don't
    specifically care about the generated link text (typically phrased
    "for further information see <xref ...>") the xref is kept.

Let me know if I missed something or further changes are needed.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  7. Re: <xref> vs <command> formatting in the docs

    Bruce Momjian <bruce@momjian.us> — 2020-10-03T16:33:31Z

    On Sat, Oct  3, 2020 at 04:57:34PM +0200, Peter Eisentraut wrote:
> On 2020-09-25 07:38, Peter Eisentraut wrote:
> > So, based on that, I think the patch proposed here is not the right one,
> > and we should instead be marking up the link sources appropriately.
> 
> I have committed a fix for this:
> 
>     Improve <xref> vs. <command> formatting in the documentation

Thanks, this is a big step forward.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee