pgcrypto: remove useless px_memset() and BF_ASM
Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: pgsql-hackers@lists.postgresql.org
Date: 2026-04-09T10:51:05Z
Lists: pgsql-hackers
Attachments
- 0001-pgcrypto-remove-unused-BF_ASM-macro.patch (text/x-diff)
Hi Hackers, In the thread about centralised architecture detection, I noticed that the BF_ASM macro in crypt-blowfish.c has never been defined to anything but 0, and the _BF_body_r() function it would call has never existed, so that can be got rid of. While investigating at that, I also noticed that px_memset(), which has the comment /* memset that must not be optimized away */, is only ever called with zero for the value, which could be better written with explicit_bzero() now that we have that. Attached are patches for both. - ilmari