Horton

Re: logical copy_replication_slot issues

Arseny Sher <a.sher@postgrespro.ru>

View thread View on postgr.es
From: Arseny Sher <a.sher@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-03-04T15:36:44Z
Lists: pgsql-hackers

Attachments

Masahiko Sawada <masahiko.sawada@2ndquadrant.com> writes:

> I've attached the updated version patch that incorporated your
> comments. I believe we're going in the right direction for fixing this
> bug. I'll register this item to the next commit fest so as not to
> forget.

I've moved confirmed_flush check to the second lookup out of paranoic
considerations (e.g. slot could have been recreated and creation hasn't
finished yet) and made some minor stylistic adjustments. It looks good
to me now.

Commits

  1. Fix consistency issues with replication slot copy