Horton

Re: BUG #16931: source code problem about commit_ts

Andy Fan <zhihuifan1213@163.com>

View thread
From: Andy Fan <zhihuifan1213@163.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, zoulx1982@163.com, pgsql-bugs@lists.postgresql.org
Date: 2025-07-03T13:33:27Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove leftover dead code from commit_ts.h.

  2. Remove COMMIT_TS_SETTS record.

  3. Fix bug in WAL replay of COMMIT_TS_SETTS record.

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

>>>
>>> Thanks for the ping! Pushed!
>> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
>> remove struct xl_commit_ts_set?
>
> You're right. I seem to have overlooked that.
>
>> After it, there is no reference to
>> xl_commit_ts_set. So Is it better clean them as well?
>
> Agreed, the patch looks good to me. Unless there are objections,
> I'll go ahead and commit it.

Thank you Fujii!

> While this could be considered an oversight in the original commit,
> it's not a bug fix, so I plan to apply it only to the master branch. 

That makes sense to me.

-- 
Best Regards
Andy Fan