Horton

Re: Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' )

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, Yuya Watari <watari.yuya@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-11-06T04:08:33Z
Lists: pgsql-hackers 
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 >> But PostgreSQL effectively requires IEEE 754 since commit
 >> 02ddd499322ab6f2f0d58692955dc9633c2150fc, right?

 Tom> That commit presumes that floats follow the IEEE bitwise
 Tom> representation, I think;

Correct. (It notably does _not_ make any assumptions about how floating
point arithmetic or comparisons work - all the computation is done in
integers.)

 Tom> but it's a long way from there to assuming that float comparisons
 Tom> do something that is explicitly *not* promised by C99.

I agree.

-- 
Andrew (irc:RhodiumToad)

Commits

  1. Fix integer-overflow edge case detection in interval_mul and pgbench.

  2. Change floating-point output format for improved performance.