pg_combinebackup PITR comparison test fix
Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: pgsql-hackers@lists.postgresql.org
Date: 2024-12-14T21:57:11Z
Lists: pgsql-hackers
Attachments
- 0001-Fix-pg_combinebackup-PITR-comparison-test.patch (text/x-diff)
Hi hackers, While I was going through the TAP tests to fix the formatting of command argument lists to be less confusing, I noticed that pg_combinebackup's 002_compare_backups.pl test accidentally ran pg_dumpall twice against the same database, thus rendering the tests useless. Fixing that revealed that there is a difference in the dumps: the tablespaces have different paths. pg_dumpall doesn't have an option to map tablespace paths, so instead I used File::Compare::compare_text() with a custom comparison function to erase the difference. - ilmari
Commits
-
pg_combinebackup: Fix PITR comparison test in 002_compare_backups
- 94e7e77a95ba 17.3 landed
- e116b703f0b9 18.0 landed