Re: The pgperltidy diffs in HEAD

Andrew Dunstan <andrew@dunslane.net> writes:

> On 2025-11-25 Tu 2:36 PM, Daniel Gustafsson wrote:
>>> On 25 Nov 2025, at 20:31, Álvaro Herrera <alvherre@kurilemu.de> wrote:
>>>
>>> On 2025-Nov-25, Daniel Gustafsson wrote:
>>>
>>>> Agreed. Perhaps something like the attached would work?
>>> Hmm, I got this
>>>
>>> src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
>>>
>>> $ ls -l /bin/sh
>>> lrwxrwxrwx 1 root root 4 feb  4  2025 /bin/sh -> dash*
>>>
>>> (Seems to work ok silently with bash.)
>> If you replace the if statement with the one below using test, does that make
>> it work?
>>
>> 	if test $? = 1; then
>>
>
> Looks to me like your original patch had == where it should have had =
>
> Your formulation above corrects that.

Even simpler, and avoiding having to move the `set -e` after the check:

PERLTIDY_VERSION=20230309
if ! $PERLTIDY -v | grep -q $PERLTIDY_VERSION; then
	echo "error: pgperltidy requires perltidy v$PERLTIDY_VERSION"
	exit 1
fi

- ilmari