Horton

Re: [HACKERS] pgbench - allow to store select results into variables

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Stephen Frost <sfrost@snowman.net>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2018-08-14T11:37:16Z
Lists: pgsql-hackers 
>>>>> "Andrew" == Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

 >>> This patch contains CRLF line endings
 >> 
 >> Alas, not according to "file" nor "hexdump" (only 0A, no 0D) on my
 >> local version, AFAICS.
 >> 
 >> What happens on the path and what is done by mail clients depending
 >> on the mime type is another question (eg text/x-diff or text/plain).

 Andrew> It's not done by my MUA, and it's present in your latest posted
 Andrew> patch. If anything I'd suspect your MUA:

The patch in the original email is in text/plain with base64 transfer
encoding, which means that CRLF line endings are mandatory. It's
actually up to the receiving MUA (or the archives webserver) to undo
that.

If the archives webserver isn't handling that then it's a bug there.

-- 
Andrew (irc:RhodiumToad)

Commits

  1. pgbench: Remove \cset

  2. pgbench: add \cset and \gset commands

  3. Adjust pgbench to allow non-ASCII characters in variable names.

  4. Refactor script execution state machine in pgbench.

  5. Allow empty queries in pgbench.