Horton

Re: The pgperltidy diffs in HEAD

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>

View thread
From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andrew Dunstan <andrew@dunslane.net>, Álvaro Herrera <alvherre@kurilemu.de>, Tom Lane <tgl@sss.pgh.pa.us>, Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-26T11:11:05Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Check for correct version of perltidy

Daniel Gustafsson <daniel@yesql.se> writes:

> [2. text/x-diff; v2_perltidyversion.diff]
> diff --git a/doc/src/sgml/func/func-string.sgml b/doc/src/sgml/func/func-string.sgml
> index 7ad1436e5f8..646b5d6d8c4 100644
> --- a/doc/src/sgml/func/func-string.sgml
> +++ b/doc/src/sgml/func/func-string.sgml
> @@ -173,7 +173,7 @@

This seems unrelated to the rest of the patch patch.

> diff --git a/src/tools/pgindent/pgperltidy b/src/tools/pgindent/pgperltidy
> index 6af27d21d55..6fac758665a 100755
> --- a/src/tools/pgindent/pgperltidy
> +++ b/src/tools/pgindent/pgperltidy
> @@ -7,6 +7,12 @@ set -e
>  # set this to override default perltidy program:
>  PERLTIDY=${PERLTIDY:-perltidy}
> 
> +PERLTIDY_VERSION=20230309
> +if ! $PERLTIDY -v | grep -q $PERLTIDY_VERSION; then
> +	echo "error: pgperltidy requires perltidy v$PERLTIDY_VERSION"

I just realised, this message should really go to stderr, i.e. have >&2
on the end.

> +	exit 1
> +fi
> +
>  . src/tools/perlcheck/find_perl_files
> 
>  find_perl_files "$@" | xargs $PERLTIDY --profile=src/tools/pgindent/perltidyrc

- ilmari