Horton

Re: Patch: Add parse_type Function

David E. Wheeler <david@justatheory.com>

View thread View on postgr.es
From: "David E. Wheeler" <david@justatheory.com>
To: Erik Wienhold <ewie@ewie.name>
Cc: Jim Jones <jim.jones@uni-muenster.de>, jian he <jian.universality@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pavel Stehule <pavel.stehule@gmail.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, pgsql-hackers@lists.postgresql.org
Date: 2024-03-09T01:42:07Z
Lists: pgsql-hackers

Attachments

On Mar 7, 2024, at 23:39, Erik Wienhold <ewie@ewie.name> wrote:

> I think you need to swap the examples.  The text mentions the error case
> first and the NULL case second.

🤦🏻‍♂️

Thanks, fixed in the attached patch.

David

Commits

  1. Add to_regtypemod function to extract typemod from a string type name.

  2. Remove "#ifdef WIN32" guards from src/port/win32*.c