Horton

Re: Hash support for grouping sets

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Mark Dilger <hornschnorter@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2017-03-08T18:30:01Z
Lists: pgsql-hackers

Attachments

>>>>> "Mark" == Mark Dilger <hornschnorter@gmail.com> writes:

 Mark> Reviewing the patch a bit more, I find it hard to understand the
 Mark> comment about passing -1 as a flag for finalize_aggregates.  Any
 Mark> chance you can spend a bit more time word-smithing that code
 Mark> comment?
 
 >> Sure.
 >> 
 >> How does this look for wording (I'll incorporate it into an updated
 >> patch later):

 Mark> Much better.  Thanks!

Here's a version of the patch that obviates that comment entirely, by
moving the differences between the hashed and sorted cases out to the
separate callers of finalize_aggregates. 

-- 
Andrew (irc:RhodiumToad)

Commits

  1. Support hashed aggregation with grouping sets.