Horton

Re: test_escape: invalid option -- 'c'

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>

View thread View on postgr.es
From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Japin Li <japinli@hotmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-02-18T13:11:11Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:

> On Tue, Feb 18, 2025 at 11:12:13AM +0800, Japin Li wrote:
>> When I test test_escape, I find the usage of test_escape declares it
>> support -c option, however, when I use it, it complains it is an
>> invalid option.
>> 
>> Here is a patch to fix it.
>
> You are right, obviously.  The only reason why this is not showing up
> is that the TAP test uses the long option --conninfo.

This was something I did consider when porting the tests to use long
options: should we leave (or add) at least one usage of every
corresponding shor option, for exactly this reason?

> Speaking of which, this had better use fat commas to combine the
> option/value pairs in these commands.

I have a local branch which converts more of the tests to the long and
fat style, I'll try to finish that up for submission soon, and look at
adding/retaining coverage for short options.

- ilmari

Commits

  1. test_escape: Fix output of --help

  2. test_escape: Fix handling of short options in getopt_long()