Horton

Re: Wrong aggregate result when sorting by a NULL value

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Ondřej Bouda <obouda@email.cz>, pgsql-bugs@postgresql.org
Date: 2018-11-02T17:34:43Z
Lists: pgsql-bugs 
>>>>> "Andres" == Andres Freund <andres@anarazel.de> writes:

 >> Andres, do you have time to look at this right now?

 Andres> Thanks for bisecting.  I'll take a look later today.

Looks like this:

+           scratch.d.agg_strict_input_check.nargs = numInputs;

should have been pertrans->numTransInputs instead?

-- 
Andrew (irc:RhodiumToad)

Commits

  1. Fix unused-variable warning.

  2. Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when nargs == 0.

  3. Fix STRICT check for strict aggregates with NULL ORDER BY columns.

  4. Expression evaluation based aggregate transition invocation.