Re: Should contrib modules install .h files?
Andrew Gierth <andrew@tao11.riddles.org.uk>
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
Andres Freund <andres@anarazel.de>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-09-15T20:03:47Z
Lists: pgsql-hackers
Attachments
- plxs.patch (text/x-patch) patch
>>>>> "Andrew" == Andrew Gierth <andrew@tao11.riddles.org.uk> writes: Andrew> So what I propose to do is to commit a cleaned-up version of Andrew> the patch posted above, with these changes: Andrew> - install all the plpy_*.h headers, not just a few; I know of no reason Andrew> to exclude any of them, and in the absence of feedback it seems Andrew> better to install them all; Andrew> - tidy up the makefile variables in the python transform modules to Andrew> remove some duplication Andrew> - fix Mkvcbuild.pm to account for the changes Andrew> This will allow hstore_plperl etc. to stand as examples of how Andrew> to do cross-module #includes both in and out of tree. Andrew> I'll post the patch for review shortly. And here it is. -- Andrew (irc:RhodiumToad)
Commits
-
Fix out-of-tree build for transform modules.
- f1ca5a654d5d 11.0 landed
- 60f6756f9225 12.0 landed
-
Provide for contrib and pgxs modules to install include files.
- df163230b92b 12.0 landed
- d06eebce5fa4 11.0 landed