Horton

Re: fast defaults in heap_getattr vs heap_deform_tuple

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2019-02-06T10:25:56Z
Lists: pgsql-hackers 
>>>>> "Andres" == Andres Freund <andres@anarazel.de> writes:

 >> Cool. Here's the patch that I, after some commit message polishing,
 >> plan to commit to 11 and master to fix the issue at hand.

 Andres> And pushed.

Sorry I didn't spot this earlier, but... in the backpatch to v11, is the
expansion of the trigger tuple really unnecessary now? Since
heap_getattr is a macro, C-language triggers that aren't recompiled
won't see the default? So perhaps the expansion should be left in?

-- 
Andrew (irc:RhodiumToad)

Commits

  1. Fix heap_getattr() handling of fast defaults.

  2. Fast default trigger and expand_tuple fixes