Re: Synchronize with imath upstream

Andrew Gierth <andrew@tao11.riddles.org.uk>

From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Date: 2019-02-03T07:07:36Z
Lists: pgsql-hackers
>>>>> "Noah" == Noah Misch <noah@leadboat.com> writes:

 >> I found it much simpler to strip out -Wdeclaration-after-statement
 >> instead:
 >> 
 >> $(RYU_OBJS): override CFLAGS := $(filter-out -Wdeclaration-after-statement,$(CFLAGS))

 Noah> The -Wno-declaration-after-statement approach takes eight lines
 Noah> of code, and the filter-out approach takes one. On the other
 Noah> hand, using $(filter-out) changes any runs of whitespace to
 Noah> single spaces ("$(filter-out foo,a b c)" yields "a b c"). We do
 Noah> risk that with CPPFLAGS and LDFLAGS in a few places. I don't want
 Noah> to proliferate that practice, because it changes semantics of
 Noah> CFLAGS containing -DFOO="arbitrary text".

In that case I propose that we avoid the whole issue by removing
-Wdeclaration-after-statement entirely.

So far, expressed opinions have run about 4:2 in favour of allowing
mixed declarations and code.

-- 
Andrew (irc:RhodiumToad)


Commits

  1. Import changes from IMath versions (1.3, 1.29].

  2. Cherry-pick security-relevant fixes from upstream imath library.