Horton

Re: BUG #16931: source code problem about commit_ts

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Andy Fan <zhihuifan1213@163.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, zoulx1982@163.com, pgsql-bugs@lists.postgresql.org
Date: 2025-07-02T08:44:30Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove leftover dead code from commit_ts.h.

  2. Remove COMMIT_TS_SETTS record.

  3. Fix bug in WAL replay of COMMIT_TS_SETTS record.


On 2025/07/02 10:42, Andy Fan wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> 
> Hi,
> 
>> On 2021/04/10 7:42, Alvaro Herrera wrote:
>>> On 2021-Mar-24, Fujii Masao wrote:
>>>
>>>> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
>>>> index 7ebd3d35ef..26bad44b96 100644
>>>> --- a/src/backend/access/rmgrdesc/committsdesc.c
>>>> +++ b/src/backend/access/rmgrdesc/committsdesc.c
>>>> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>>>>    		appendStringInfo(buf, "pageno %d, oldestXid %u",
>>>>    						 trunc->pageno, trunc->oldestXid);
>>>>    	}
>>>> -	else if (info == COMMIT_TS_SETTS)
>>> You have not pushed this one, right?  I think we should do it now.
>>
>> Thanks for the ping! Pushed!
> 
> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
> remove struct xl_commit_ts_set?

You're right. I seem to have overlooked that.


> After it, there is no reference to
> xl_commit_ts_set. So Is it better clean them as well?

Agreed, the patch looks good to me. Unless there are objections,
I'll go ahead and commit it. While this could be considered an oversight
in the original commit, it's not a bug fix, so I plan to apply it
only to the master branch.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation