Horton

Re: Possible bug: SQL function parameter in window frame definition

Andrew Gierth <andrew@tao11.riddles.org.uk>

View thread View on postgr.es
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-10-02T16:20:11Z
Lists: pgsql-hackers, pgsql-general 
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 Tom> Hm. transformRuleStmt already does special-case utility statements
 Tom> to some extent, so my inclination would be to make it do more of
 Tom> that. However, it looks like that might end up with rather
 Tom> spaghetti-ish code, as that function is kind of messy already.

 Tom> Or we could abandon the notion of adding the assertion. I don't
 Tom> know how much work it's worth.

Fixing transformRuleStmt just pushes the issue along another step:
InsertRule wants to do recordDependencyOnExpr on the rule actions,
which just does find_expr_references_walker.

I'm going to leave the assertion out for now and put in a comment for
future reference.

-- 
Andrew (irc:RhodiumToad)

Commits

  1. Selectively include window frames in expression walks/mutates.