Re: add more frame types in window functions (ROWS)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Hitoshi Harada <umi.tanuki@gmail.com>, pgsql-hackers@postgresql.org
Date: 2009-12-05T06:06:07Z
Lists: pgsql-hackers
Andrew Gierth <andrew@tao11.riddles.org.uk> writes: > If we're going to change the interface in this way, there should, IMO, > be enough of a change that old code fails to compile; e.g. by renaming > wincontext to partition_context or some equivalent change. Agreed --- if we have to break things, break them obviously not silently. I don't have time right now to think about this issue in detail, but if those are the alternatives I think the choice is clear. Quietly adding a memory leak to code that used to work well is not acceptable. regards, tom lane