Horton

Re: pgsql: Avoid improbable PANIC during heap_update.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>, pgsql-committers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>
Date: 2022-10-01T05:13:13Z
Lists: pgsql-hackers 
Peter Geoghegan <pg@bowt.ie> writes:
> I think that the heap_delete() issue is probably in all PG versions.

Yeah, that's what I'm afraid of ...

> I am not aware of any reason why we should need the heap_update()
> fixes to be backpatched any further.

How so?  AFAICS these are exactly the same oversight, ie failure
to deal with the all-visible bit getting set partway through the
operation.  You've explained how that can happen.

			regards, tom lane

Commits

  1. Avoid improbable PANIC during heap_update, redux.

  2. Fix race condition where heap_delete() fails to pin VM page.

  3. Avoid improbable PANIC during heap_update.