Horton

Re: max_slot_wal_keep_size and wal_keep_segments

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Fujii Masao <masao.fujii@oss.nttdata.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: alvherre@2ndquadrant.com, pgsql-hackers@postgresql.org
Date: 2020-07-14T11:30:24Z
Lists: pgsql-hackers 
On 7/14/20 12:00 AM, Fujii Masao wrote:
> 
> The patch was no longer applied cleanly because of recent commit.
> So I updated the patch. Attached.
> 
> Barring any objection, I will commit this patch.

This doesn't look right:

+   the <xref linkend="guc-wal-keep-size"/> most recent megabytes
+   WAL files plus one WAL file are

How about:

+   <xref linkend="guc-wal-keep-size"/> megabytes of
+   WAL files plus one WAL file are

Other than that, looks good to me.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. doc: Mention the rename of wal_keep_segments GUC in release note.

  2. Rename wal_keep_segments to wal_keep_size.