Re: Why do we have perl and sed versions of Gen_dummy_probes?
Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker )
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Andres Freund <andres@anarazel.de>,
Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org,
Michael Paquier <michael@paquier.xyz>,
Craig Ringer <craig.ringer@enterprisedb.com>
Date: 2021-05-10T11:16:12Z
Lists: pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes: > On 07.05.21 20:31, Andrew Dunstan wrote: >> On 5/7/21 1:20 PM, Andres Freund wrote: >>> On 2021-05-07 11:19:02 -0400, Andrew Dunstan wrote: >>>> Here's a patch that adds the README and also adds a Makefile recipe for >>>> regenerating Gen_dummy_probes.pl after the sed script is changed. On my >>>> system at least the recipe is idempotent. >>> Nice! Thanks for this work. >> >> de nada. pushed. > > This recipe doesn't produce a Gen_dummy_probes.pl that matches exactly > the one that is there now. If this is going to be the preferred method, > then we should generate it once so that it matches going forward. Which version of perltidy do you have installed? For me it generates identical versions using any of 20170521 (per src/tools/pgindent/README), 20201207 (what I happened to have installed before), and 20210402 (the latest). Also, what does the difference look like? - ilmari -- - Twitter seems more influential [than blogs] in the 'gets reported in the mainstream press' sense at least. - Matt McLeod - That'd be because the content of a tweet is easier to condense down to a mainstream media article. - Calle Dybedahl
Commits
-
Tweak generation of Gen_dummy_probes.pl
- 0bf62931cae0 14.0 landed
-
Add a README and Makefile recipe for Gen_dummy_probes.pl
- 8292c0675a79 14.0 landed
-
Remove dependency on psed for MSVC builds.
- 5d0320105699 9.6.0 cited