Horton

Re: psql - improve test coverage from 41% to 88%

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>, Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, vignesh C <vignesh21@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, David Steele <david@pgmasters.net>
Date: 2020-08-03T22:44:03Z
Lists: pgsql-hackers 
On 8/3/20 3:34 PM, Fabien COELHO wrote:
>
>
> I'm quite lost about Expect portability discussion wrt windows, it is
> unclear to me whether it is expected to work there or not.



Sorry if I was unclear. Expect will not work on Windows. Nor will use of
IO::Pty  or IO::Tty, which are what Expect uses under the hood. So use
of any of that needs to be done just as it is done on
010_tab_completion.pl, i.e.


    eval { require IO::Pty; };
    if ($@)
    {
        plan skip_all => 'IO::Pty is needed to run this test';
    }


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Improve coverage of psql for backslash commands with \if and \elif

  2. Fix comment in psql's describe.c