Re: On /*----- comments
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Daniel Gustafsson <daniel@yesql.se>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-04T18:36:43Z
Lists: pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes: > On 03/07/2023 11:48, Daniel Gustafsson wrote: > On 30 Jun 2023, at 17:22, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> Seems reasonable; the trailing dashes eat a line without adding much. >> +1 > Pushed a patch to remove the end-guard from the example in the pgindent > README. And fixed the bogus end-guard in walsender.c. I don't see any actual push? > I'm not sure there is a universal best length. It depends on the comment > what looks best. The very long ones in particular would not look good on > comments in a deeply indented block. So I think the status quo is fine. OK, no strong feeling about that here. regards, tom lane
Commits
-
Change example in pgindent README on "/*-----" comments.
- 5e8068f04e13 17.0 landed
-
Refactor WAL file-reading code into WALRead()
- 0dc8ead46363 13.0 cited