Re: Prep object creation hooks, and related sepgsql updates
Dimitri Fontaine <dimitri@2ndquadrant.fr>
From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-12-16T16:58:59Z
Lists: pgsql-hackers
Hi, Kohei KaiGai <kaigai@kaigai.gr.jp> writes: > The attached patches are revised ones. > I added explanations of DDL permissions on creation time added by these patches, > and added a few regression test cases. The whole patches are now against contrib/sepgsql, which seems to me to be a good news, but means I'm not skilled to help review further. I'm unsure about marking that as “ready for commiter” but I'm definitely done myself. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support As seen here, contrib only patch now: [2. application/octet-stream; pgsql-v9.2-sepgsql-create-permissions-part-4.v2.proc.patch]... contrib/sepgsql/expected/create.out | 13 +++++++- contrib/sepgsql/proc.c | 55 +++++++++++++++++++++++++++++++---- contrib/sepgsql/sql/create.sql | 7 ++++ 3 files changed, 68 insertions(+), 7 deletions(-) [3. application/octet-stream; pgsql-v9.2-sepgsql-create-permissions-part-2.v2.schema.patch]... contrib/sepgsql/expected/create.out | 4 +++ contrib/sepgsql/schema.c | 50 ++++++++++++++++++++++++++++++++--- contrib/sepgsql/sql/create.sql | 6 ++++ 3 files changed, 56 insertions(+), 4 deletions(-) [4. application/octet-stream; pgsql-v9.2-sepgsql-create-permissions-part-3.v2.relation.patch]... contrib/sepgsql/expected/create.out | 46 +++++++++++ contrib/sepgsql/hooks.c | 70 +++++++++++++++++- contrib/sepgsql/relation.c | 144 +++++++++++++++++++++++++++++------ contrib/sepgsql/sql/create.sql | 18 +++++ 4 files changed, 254 insertions(+), 24 deletions(-) [5. application/octet-stream; pgsql-v9.2-sepgsql-create-permissions-part-1.v2.database.patch]... contrib/sepgsql/database.c | 91 ++++++++++++++++++++++---- contrib/sepgsql/expected/create.out | 19 ++++++ contrib/sepgsql/hooks.c | 122 ++++++++++++++++++++++++---------- contrib/sepgsql/sepgsql.h | 3 +- contrib/sepgsql/sql/create.sql | 15 ++++ contrib/sepgsql/test_sepgsql | 2 +- doc/src/sgml/sepgsql.sgml | 30 ++++++++- 7 files changed, 231 insertions(+), 51 deletions(-)