Re: Ryu floating point output patch
Andrew Gierth <andrew@tao11.riddles.org.uk>
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>,
Andres Freund <andres@anarazel.de>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-14T20:06:30Z
Lists: pgsql-hackers
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes: Tom> (Still, you might want to try to automate and document the coding Tom> format conversion steps, along the line of what I've done recently Tom> for our copy of tzcode.) Working around our declaration-after-statement prohibition required manually moving some lines of code, manually separating some declarations from their assignments (removing const qualifiers), and as a last resort introducing new code blocks. I doubt it could be automated in any sane way. (This might be an argument to relax that rule.) Mechanical search-and-replace accounted for the _t suffix on types, the addition of the UINT64CONSTs, and changing assert to Assert; that much could be automated. pgindent did a pretty horrible job on the comments, a script could probably do better. I guess removal of the unwanted #ifs could be automated without too much difficulty. (But I'm not likely going to do any of this in the forseeable future, because I don't expect it to be useful.) -- Andrew (irc:RhodiumToad)
Commits
-
Provide an extra-float-digits setting for pg_dump / pg_dumpall
- af25bc03e17e 12.0 landed
-
Change floating-point output format for improved performance.
- 02ddd499322a 12.0 landed
-
Use strtof() and not strtod() for float4 input.
- f397e08599a3 12.0 landed