Re: [v9.1] sepgsql - userspace access vector cache

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kohei Kaigai <Kohei.Kaigai@EMEA.NEC.COM>
Cc: Robert Haas <robertmhaas@gmail.com>, Kohei KaiGai <kaigai@kaigai.gr.jp>, Yeb Havinga <yebhavinga@gmail.com>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-08-19T15:46:07Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Remove the limit on the number of entries allowed in catcaches, and

Kohei Kaigai <Kohei.Kaigai@EMEA.NEC.COM> writes:
>> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
>> Well, they should get at least a warning from referencing undefined
>> functions, no?

> Yes. User should notice warning messages due to undefined symbols.
> I'm not certain whether it makes sense to add -Werror here, or not.

Hmm.  That would help catch the problem, but I'm a bit uncomfortable
with adding -Werror in relatively new code.  On the other hand, it's
not like we expect sepgsql to work on a wide variety of systems, so
maybe it'd be OK.

On the whole I don't think it's worth messing with the cflags for this.

			regards, tom lane