Horton

Re: [PATCH] document

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Justin Pryzby <pryzby@telsasoft.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers@postgresql.org
Date: 2021-10-04T06:18:04Z
Lists: pgsql-hackers

Attachments


On 2021/08/26 1:39, Justin Pryzby wrote:
> On Wed, Aug 25, 2021 at 09:50:13AM -0400, Tom Lane wrote:
>> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>>> When I applied the patch to the master, I found that the table entries for
>>> those function were added into the table for aclitem functions in the docs.
>>> I think this is not valid position and needs to be moved to the proper one
>>> (maybe the table for system catalog information functions?).
>>
>> You have to be very careful these days when applying stale patches to
>> func.sgml --- there's enough duplicate boilerplate that "patch' can easily
>> be fooled into dumping an addition into the wrong place.  I doubt that
>> the submitter meant the doc addition to go there.
> 
> I suppose one solution to this is to use git format-patch -U11 or similar, at
> least for doc/

Yes. I moved the desriptions of the function into the table for
system catalog information functions, and made the patch by using
git diff -U6. Patch attached. Barring any objection, I'm thinking
to commit it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. doc: Document pg_encoding_to_char() and pg_char_to_encoding().

  2. Add builtin functions: